Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lexical to 0.11.1 #40

Open
timofei-iatsenko opened this issue Jun 20, 2023 · 4 comments
Open

update lexical to 0.11.1 #40

timofei-iatsenko opened this issue Jun 20, 2023 · 4 comments

Comments

@timofei-iatsenko
Copy link

I tried to update it locally via yarn's resolutions, but it seems there are breaking changes between current and latest version.

TypeError: Class extends value undefined is not a constructor or null
at Object. (/Users/tim/projects/roadtravel-main-landing/backend/node_modules/payload-plugin-lexical/src/features/emojipicker/plugins/index.tsx:26:27)

@timofei-iatsenko timofei-iatsenko changed the title update lexical for 0.11.1 update lexical to 0.11.1 Jun 20, 2023
@AlessioGr
Copy link
Owner

I tried to update it locally via yarn's resolutions, but it seems there are breaking changes between current and latest version.

TypeError: Class extends value undefined is not a constructor or null
at Object. (/Users/tim/projects/roadtravel-main-landing/backend/node_modules/payload-plugin-lexical/src/features/emojipicker/plugins/index.tsx:26:27)

oh yea, updating needs some extra work. Usually, I go through each commit of the lexical playground and copy the relevant stuff they changed there.

Will do that once I find time! Don't think there have been any too exciting changes anyways

@timofei-iatsenko
Copy link
Author

I personally encountered a problem on our project. When a document has tables inside in some circumstances copy/paste stop working. When you trying to copy it show some not very useful error in console and all further processing is stopped. So i decided to check on new version first and that report a bug if it doesn't fixed in upstream.

@AlessioGr
Copy link
Owner

I personally encountered a problem on our project. When a document has tables inside in some circumstances copy/paste stop working. When you trying to copy it show some not very useful error in console and all further processing is stopped. So i decided to check on new version first and that report a bug if it doesn't fixed in upstream.

Yep, that's #5. Already reported the bug upstream - sadly it has not been fixed in the latest version yet.

There's an open PR which fixes the issue, also linked in the upstream issue, but it's currently stalled. Might have to check it out and finish it myself

@timofei-iatsenko
Copy link
Author

i saw this issue, but i think it's a different one. Firstly i have only one editor on the page, secondly the error message is different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants