Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency paths in Windows use back slash, though they should use the canonical forward slash #345

Closed
abhay-agarwal opened this issue Aug 6, 2024 · 1 comment · Fixed by #346
Labels
bug Something isn't working

Comments

@abhay-agarwal
Copy link

On windows, generated definitions are created with backslashes as opposed to forward slashes:

import type { MyType } from "..\\my\\windows\\path";

// should be:
import type { MyType } from "../my/windows/path";

Rust and typescript are smart enough to handle unix paths, and the difference creates some noise when working across windows and os x environments. Note: I believe this only happens when the dependency includes "..". It seems like there's a migration to a new path api in the works, so that might address this.

@abhay-agarwal abhay-agarwal added the bug Something isn't working label Aug 6, 2024
@NyxCode
Copy link
Collaborator

NyxCode commented Aug 6, 2024

Thanks for opening an issue for this.
I've been aware of this, but since it doesn't break anything & Windows use is pretty rare this hasn't been fixed yet.
I do agree though - the generated files should be reproducible across platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants