callx test will always pass

[hawkinsw]

bpf_conformance/tests/callx.data

Line 7 in 56950c4

mov %r0, 2

Given the unconditional mov of 0x2 to %r0, will this test always pass?

cc @dthaler

[dthaler]

Not specific to callx.data. This test was derived from call_unwind_fail.data which has the same behavior.

[hawkinsw]

Glad I wasn't seeing ghosts! I will fix both of those! Thank you for confirming!

[hawkinsw]

Unfortunately because the callx.data and the call_unwind_fail.data test rely on the behavior of the implementation-under-test's unwind helper function, I don't know if there is a better way to write a test.

Perhaps we could extend the conformance system so that a test could also specify a particular implementation of a helper function in order to have a test pass?