Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting Tracks for Recording to File #778

Closed
krakow10 opened this issue May 27, 2022 · 6 comments
Closed

Selecting Tracks for Recording to File #778

krakow10 opened this issue May 27, 2022 · 6 comments
Assignees
Labels
bug Confirmed as bug

Comments

@krakow10
Copy link
Contributor

krakow10 commented May 27, 2022

Describe the bug
Recording to files does not write the selected audio tracks. Instead, it ignores the tracks selection and duplicates the first audio track for each live source audio track (6 duplicates in my case).

To Reproduce
Steps to reproduce the behavior:

  1. Stream a live source with multiple audio tracks. (In my case 6)
  2. Call startRecord REST API function with a track selection such as:
    curl -d '{ "id" : "vod", "stream": { "name": "quat", "tracks":[0,3,6] } }' -H 'Authorization: Basic '"${OME_AUTH_KEY}" -H 'Content-Type: application/json' http://192.168.1.8:8081/v1/vhosts/default/apps/hw60:startRecord

Expected behavior
Selected audio tracks are written to the output file.

Logs
ovenmediaengine.log

Server (please complete the following information):

  • OS: Debian 11 Proxmox container
  • OvenMediaEngine Version: d02b736
  • Branch: master

Additional context
As far as I am aware this issue is similar to the issue I had with #685, but for the Recording publisher instead of RTMP Push.

@krakow10 krakow10 added the bug Confirmed as bug label May 27, 2022
@Keukhan
Copy link
Member

Keukhan commented May 30, 2022

@krakow10

Thanks for the reporting.
I've been busy with other things these days, so my response is late.
There was a bug where only the selected track could not be recorded. All tracks were being recorded.
I solved the problem.
Test it with the master version.

da0d9cb

Thanks

@krakow10
Copy link
Contributor Author

krakow10 commented May 30, 2022

I tested your new commit with 2, and 6 audio tracks streamed from the live source, and trying 2, 4, and 6 selected audio tracks for recording. My tests show that the behaviour has changed so that the number of audio tracks selected is respected rather than ignored. However, the recorded audio tracks are all duplicates of the first live source audio track.

@stale
Copy link

stale bot commented Jul 29, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 29, 2022
@krakow10
Copy link
Contributor Author

krakow10 commented Jul 30, 2022

I tested this on v0.14.4 and the issue that all recorded audio tracks are duplicates of the first track remains.

@stale stale bot removed the stale label Jul 30, 2022
@Keukhan Keukhan self-assigned this Aug 1, 2022
@Keukhan
Copy link
Member

Keukhan commented Aug 4, 2022

@krakow10

I've been working on other important things in the meantime, so I've only now solved this problem.
There was an issue where bypassed audio tracks were duplicated.

fd2af0e...42b5f42

I applied it to the master, so test it

Thanks.

@krakow10
Copy link
Contributor Author

krakow10 commented Aug 4, 2022

I tested your changes and the issue is resolved for my configuration, thanks for your great work!

@krakow10 krakow10 closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed as bug
Projects
None yet
Development

No branches or pull requests

2 participants