-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic UI for LED settings #4117
Comments
Note: This enhancement may be part of (or prequel to) Settings rewrite which "is supposed to read all information from cfg.json file". To allow educated UI the following must also be provided for particular LED type:
|
Should the power and memory being calculated by the UI or by the bus? |
If it is to be done by UI then UI needs to be informed of HW limitations and capabilities. Difficult. |
If the goal is that we can change/add what output options are added without needing to add LED type specific code to the UI, then it has to be on the backend that these details are calculated. That might be taking that requirement too strongly/literally however? |
The request payload and response should be very small so really shouldn't be an issue. If we do see issues than that's really an indication of bigger issues with the webserver that needs attention |
You are welcome to join @willmmiles 's efforts in making AWS better. 😄 Back to topic, I am starting to see issues with compile-time selections of possible bus types and their capabilities. But changing that may require rethinking entire bus logic I am not willing to take. Your PR may be a step in the right direction but will stil require profoud changes in BusManager to be fully run-time configurable. |
The BusManager supplies the list of LED Types
Once a type has been selected then config requirements are returned for this type.
This needs to cater for this like which pins are needed, colour order etc
For each required value the following are required
The text was updated successfully, but these errors were encountered: