fix: Fix AgoraVideoView not showing correctly when reusing the same VideoViewController #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littleGnAl
added a commit
that referenced
this pull request
Jun 30, 2023
…ideoViewController (#1169) * fix: Fix AgoraVideoView not show correctly when resued the same VideoViewController
littleGnAl
added a commit
that referenced
this pull request
Jun 30, 2023
* fix: Fix VideoViewController state not correct when the AgoraVideoView is reused * fix: Fix AgoraVideoView not showing correctly when reusing the same VideoViewController (#1169) * fix: Fix AgoraVideoView not show correctly when resued the same VideoViewController * ++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Fix
AgoraVideoViewnot showing correctly when resued the sameVideoViewController.When reusing the same
VideoViewController, and create/dispose of theAgoraVideoViewmultiple times, theVideoViewControllerBaseMixin._isDisposeRenderflag is not reset correctly in thesetupView, which causes thedisposeRendernot to be called.It's better to use state management for the
AgoraVideoViewin the future, at this time, just fix the bug first.