Skip to content

Commit 3cc405b

Browse files
vramikhmlnarik
authored andcommitted
KEYCLOAK-8542 Remove resteasy workaround - KeycloakStringEntityFilter
1 parent a48698c commit 3cc405b

File tree

5 files changed

+11
-50
lines changed

5 files changed

+11
-50
lines changed

distribution/feature-packs/server-feature-pack/src/main/resources/modules/system/layers/keycloak/org/keycloak/keycloak-server-subsystem/main/server-war/WEB-INF/web.xml

+5
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,11 @@
3838
<async-supported>true</async-supported>
3939
</servlet>
4040

41+
<context-param>
42+
<param-name>resteasy.disable.html.sanitizer</param-name>
43+
<param-value>true</param-value>
44+
</context-param>
45+
4146
<listener>
4247
<listener-class>org.keycloak.services.listeners.KeycloakSessionDestroyListener</listener-class>
4348
</listener>

services/src/main/java/org/keycloak/services/filters/KeycloakStringEntityFilter.java

-45
This file was deleted.

services/src/main/java/org/keycloak/services/resources/KeycloakApplication.java

-5
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
import org.keycloak.services.DefaultKeycloakSessionFactory;
4444
import org.keycloak.services.ServicesLogger;
4545
import org.keycloak.services.error.KeycloakErrorHandler;
46-
import org.keycloak.services.filters.KeycloakStringEntityFilter;
4746
import org.keycloak.services.filters.KeycloakTransactionCommitter;
4847
import org.keycloak.services.managers.ApplianceBootstrap;
4948
import org.keycloak.services.managers.RealmManager;
@@ -128,10 +127,6 @@ public KeycloakApplication(@Context ServletContext context, @Context Dispatcher
128127
classes.add(JsResource.class);
129128

130129
classes.add(KeycloakTransactionCommitter.class);
131-
132-
// Workaround for KEYCLOAK-8461. TODO: Remove it once corresponding issue is fixed in Wildfly/Resteasy
133-
classes.add(KeycloakStringEntityFilter.class);
134-
135130
classes.add(KeycloakErrorHandler.class);
136131

137132
singletons.add(new ObjectMapperResolver(Boolean.parseBoolean(System.getProperty("keycloak.jsonPrettyPrint", "false"))));

testsuite/integration-arquillian/servers/auth-server/undertow/src/main/java/org/keycloak/testsuite/arquillian/undertow/KeycloakOnUndertow.java

+4
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import org.jboss.arquillian.container.spi.client.protocol.metadata.ProtocolMetaData;
3737
import org.jboss.arquillian.container.spi.client.protocol.metadata.Servlet;
3838
import org.jboss.logging.Logger;
39+
import org.jboss.resteasy.plugins.server.servlet.ResteasyContextParameters;
3940
import org.jboss.resteasy.plugins.server.undertow.UndertowJaxrsServer;
4041
import org.jboss.resteasy.spi.ResteasyDeployment;
4142
import org.jboss.shrinkwrap.api.Archive;
@@ -78,6 +79,9 @@ private DeploymentInfo createAuthServerDeploymentInfo() {
7879
ResteasyDeployment deployment = new ResteasyDeployment();
7980
deployment.setApplicationClass(KeycloakApplication.class.getName());
8081

82+
// RESTEASY-2034
83+
deployment.setProperty(ResteasyContextParameters.RESTEASY_DISABLE_HTML_SANITIZER, true);
84+
8185
DeploymentInfo di = undertow.undertowDeployment(deployment);
8286
di.setClassLoader(getClass().getClassLoader());
8387
di.setContextPath("/auth");

testsuite/integration-arquillian/tests/pom.xml

+2
Original file line numberDiff line numberDiff line change
@@ -643,6 +643,7 @@
643643
<auth.server.config.property.value>standalone.xml</auth.server.config.property.value>
644644
<auth.server.config.dir>${auth.server.home}/standalone/configuration</auth.server.config.dir>
645645
<h2.version>1.3.173</h2.version>
646+
<surefire.memory.settings>-Xms512m -Xmx1024m -XX:MetaspaceSize=96m -XX:MaxMetaspaceSize=256m</surefire.memory.settings>
646647
</properties>
647648
<dependencies>
648649
<dependency>
@@ -667,6 +668,7 @@
667668
<auth.server.config.property.value>standalone.xml</auth.server.config.property.value>
668669
<auth.server.config.dir>${auth.server.home}/standalone/configuration</auth.server.config.dir>
669670
<h2.version>1.3.173</h2.version>
671+
<surefire.memory.settings>-Xms512m -Xmx1024m -XX:MetaspaceSize=96m -XX:MaxMetaspaceSize=256m</surefire.memory.settings>
670672
</properties>
671673
<dependencies>
672674
<dependency>

0 commit comments

Comments
 (0)