We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Good afternoon.
Current implementation doesn't accept context.Context on function (https://github.com/AfterShip/email-verifier/blob/main/verifier.go#L63):
context.Context
func (v *Verifier) Verify(email string) (*Result, error) {
that doesn't allow users to cancel the request if it takes too long to execute it.
Underneath net package is used without context (f.e.: mx, err := net.LookupMX(domain) (https://github.com/AfterShip/email-verifier/blob/main/mx.go#L14)). However, net pakcage includes Resolver functionality which accepts context as an argument.
net
mx, err := net.LookupMX(domain)
I assume, changing the signature of the function with new input arg ctx context.Context would be a breaking change.
ctx context.Context
v2
I guess, I am happy to contribute and provide this feature, but asking in advance if you have any general concerns about it.
Thank you!
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Good afternoon.
Current implementation doesn't accept
context.Context
on function (https://github.com/AfterShip/email-verifier/blob/main/verifier.go#L63):that doesn't allow users to cancel the request if it takes too long to execute it.
Underneath
net
package is used without context (f.e.:mx, err := net.LookupMX(domain)
(https://github.com/AfterShip/email-verifier/blob/main/mx.go#L14)). However,net
pakcage includes Resolver functionality which accepts context as an argument.I assume, changing the signature of the function with new input arg
ctx context.Context
would be a breaking change.v2
of the package with this and any other changes in mind?I guess, I am happy to contribute and provide this feature, but asking in advance if you have any general concerns about it.
Thank you!
The text was updated successfully, but these errors were encountered: