Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible error when removing leading e or - #16

Closed
Aethese opened this issue Sep 13, 2022 · 5 comments
Closed

possible error when removing leading e or - #16

Aethese opened this issue Sep 13, 2022 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested

Comments

@Aethese
Copy link
Owner

Aethese commented Sep 13, 2022

I just noticed I set it to remove more characters than I may want to remove. need to just double check if this is working fine although I trust my past self

@Aethese Aethese added help wanted Extra attention is needed question Further information is requested labels Sep 13, 2022
@Aethese
Copy link
Owner Author

Aethese commented Sep 13, 2022

also the round place, if it's high enough to be affected by this, needs to be lowered so it doesn't error

@Aethese Aethese added the bug Something isn't working label Sep 13, 2022
@Aethese
Copy link
Owner Author

Aethese commented Sep 13, 2022

after a test, there are definitely problems with removing 'e' as seen here. can't reproduce problems with dash for now. for archive purposes, here are the before and after:

before: 4249267578125e
after: 2424926757812

as you can tell it also removed the 5 at the end

@Aethese
Copy link
Owner Author

Aethese commented Sep 13, 2022

possibly fixed in v1.4.4 with many changes. just gonna hop so and if not, I can reopen this at a later date

@Aethese Aethese closed this as completed Sep 13, 2022
@Aethese
Copy link
Owner Author

Aethese commented Sep 13, 2022

just figured out with this debug text: [Rounder] Debug info: 7220458984375e-, 7220458984375 that it is e- at the end, not just -. I did guess right haha

@Aethese
Copy link
Owner Author

Aethese commented Sep 22, 2022

removing 1 or 2 off round place when the round place doesn't even touch the removed characters is a bad idea. only if the round place is one less or is on the characters being removed, then lower the round place

@Aethese Aethese reopened this Sep 22, 2022
@Aethese Aethese closed this as completed Sep 23, 2022
Aethese added a commit that referenced this issue Sep 23, 2022
fix issues when removing characters (#16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant