Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger transport should be configurable #28

Open
finkinfridom opened this issue Dec 19, 2023 · 3 comments
Open

logger transport should be configurable #28

finkinfridom opened this issue Dec 19, 2023 · 3 comments

Comments

@finkinfridom
Copy link

I just installed your plugin and noticed the transport.target is hard-coded

target: 'pino-pretty'

while, for our scenario, should be configurable (as we're using opentelemetry and Grafana stack to ingest logs).
Would it be possible to update it?
Thanks in advance

@sangallimarco
Copy link
Contributor

Hi,
Sure, please open a PR with the proposed change and we will take a look at it

Best
Marco

@finkinfridom
Copy link
Author

finkinfridom commented Dec 20, 2023

@sangallimarco created PR: #29. I noticed your jest tests are failing (also on master branch). Am I wrong?

@sangallimarco
Copy link
Contributor

sangallimarco commented Jan 9, 2024

here the fix for the failing tests: #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants