Fix SessionAuthentication LIVE url

[gcatanese]

The live url of the SessionAuthentication API is incorrect: this PR fixes the bug and adds a test.

This is a short-term solution, we will revise the approach and use the url from the OpenAPI servers element.

Fix #1578

[gemini-code-assist]

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the SessionAuthentication API where the live environment URL was incorrectly configured. The changes include a direct fix to ensure the proper live URL is constructed and introduces new unit tests to verify this behavior across different environments. This is presented as an immediate solution, with a clear plan to refactor the URL handling mechanism in the future by leveraging OpenAPI definitions.

Highlights

• Bug Fix: Corrected the incorrect 'live' URL for the SessionAuthentication API, ensuring proper endpoint resolution.
• Test Coverage: Added new test cases to validate the correct base URL generation for SessionAuthentication in both TEST and LIVE environments.
• Future Improvement: This fix is a short-term solution; a future approach will involve using the URL from the OpenAPI 'servers' element for more robust handling.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request addresses an incorrect live URL for the SessionAuthentication API and includes a new test case. The code adds a specific case to handle the /authe/ path, replacing the test URL with the live URL. The added test cases verify the correct URL is built for both test and live environments.

[benjamin-deutsch-swap]

I think in general this code should be refactored to something like this instead of having hard coded values

The regex is just an example not an accurate one

protected createBaseUrl(url: string): string {
    const { environment, liveEndpointUrlPrefix } = this.client.config;

    if (!url) throw new Error("Endpoint URL must be provided.");

    // Non-LIVE: return test URLs as-is
    if (environment !== EnvironmentEnum.LIVE) {
        return url;
    }

    if (!liveEndpointUrlPrefix) {
        throw new Error("Live endpoint URL prefix must be provided for LIVE environment.");
    }

    // Match known Adyen domains
    const patterns = [
        // pal-test.adyen.com → {prefix}-pal-live.adyenpayments.com
        { regex: /^https:\/\/pal-test\.adyen\.com/, 
          replace: `https://${liveEndpointUrlPrefix}-pal-live.adyenpayments.com` },

        // checkout-test.adyen.com → {prefix}-checkout-live.adyenpayments.com
        { regex: /^https:\/\/checkout-test\.adyen\.com/, 
          replace: `https://${liveEndpointUrlPrefix}-checkout-live.adyenpayments.com` },

        // test.adyen.com/authe → live.adyen.com/authe
        { regex: /^https:\/\/test\.adyen\.com\/authe/, 
          replace: "https://live.adyen.com/authe" },

        // Generic: anything ending in -test.adyen.com → -live.adyen.com
        { regex: /-test\.adyen\.com/, 
          replace: "-live.adyen.com" },
    ];

    for (const { regex, replace } of patterns) {
        if (regex.test(url)) return url.replace(regex, replace);
    }

    // fallback: return unchanged if no pattern matched
    return url;
}

[gcatanese]

@benjamin-deutsch-swap Yes, very good point. Our plan is to use the servers urls from the OpenAPI spec file, instead of relying on custom logic.