Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved exception handling #34

Open
jacione opened this issue Oct 3, 2024 · 1 comment
Open

Improved exception handling #34

jacione opened this issue Oct 3, 2024 · 1 comment

Comments

@jacione
Copy link
Contributor

jacione commented Oct 3, 2024

Cohere seems to handle most exceptions by printing that something happened and then just trying to power through. I think in many cases it would be better to let it crash so that you can at least get a traceback.

@bfrosik
Copy link
Contributor

bfrosik commented Oct 3, 2024

This would make sense in a single reconstruction case, also multipeak.
For GA the cohere starts with multiple processes and if one is not successful, it gracefully closes this process and continues with the rest.
The verifier is supposed to catch problems with the configuration. We need to add verification for mp parameters.
Besides the incorrect parameters, other problems can happen. We can print the exception text in addition to the print that is currently there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants