Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape commas in the params during conversion to ubo rules #343

Closed
maximtop opened this issue Jul 27, 2023 · 1 comment
Closed

Escape commas in the params during conversion to ubo rules #343

maximtop opened this issue Jul 27, 2023 · 1 comment
Assignees
@maximtop
Labels
Priority: P4 Release: v1.9.58 Resolution: Fixed Status: Closed Version: Scriptlets v1.9

Comments

@maximtop
Copy link
Contributor

AdguardTeam/FiltersCompiler#185
@adguard-bot adguard-bot mentioned this issue Jul 28, 2023
Closed
@gorhill
Copy link
Contributor

gorhill commented Aug 8, 2023

Starting with uBO 1.51.0, it is not necessary to escape commas if quotes are used around the parameters, it's ok to provide the parameters as they are declared in AdGuard. The only conversion needed might be the scriptlet name, but in such case it's best to just bring this to my attention so that I can add an alias on uBO's side.

This was referenced Aug 9, 2023
Closed
Closed
This was referenced Aug 18, 2023
Closed
Closed
@ameshkov ameshkov mentioned this issue Sep 26, 2023
Closed
This was referenced Oct 23, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximtop maximtop

Labels
Priority: P4 Release: v1.9.58 Resolution: Fixed Status: Closed Version: Scriptlets v1.9
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gorhill @maximtop @adguard-bot