Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filters.adtidy.org returns HTTP 200 even when If-None-Match matches server ETag #1025

Closed
3 tasks done
SukkaW opened this issue Oct 10, 2024 · 2 comments
Closed
3 tasks done
Labels
A: Bug The issue is caused by a program bug

Comments

@SukkaW
Copy link

SukkaW commented Oct 10, 2024

Prerequisites

  • This problem is not related to filtering issues. Otherwise, you should read this article;
  • You're using an up-to-date version of the problematic filter;

Problem description

I regularly fetch AdGuard's filter from filters.adtidy.org. To avoid overloading AdGuard's server/CDN, I've implemented a cache based on ETag. However, I've noticed that filters.adtidy.org sometimes returns HTTP 200 instead of HTTP 304, even when the returned ETag matches the sent If-None-Match:

image image

This behavior cannot be reproduced consistently, though:

image

Proposed solution

Check the implementation of AdGuard's registry server and the CDN provider (CDN77) to make sure always returns HTTP 304 when the server ETag matches If-None-Match.

Privacy

  • I agree to follow this condition
@SukkaW SukkaW added the A: Bug The issue is caused by a program bug label Oct 10, 2024
@SukkaW SukkaW changed the title AdGuard Filter CDN returns 200 even when If-None-Match matches server ETag filters.adtidy.org returns HTTP 200 even when If-None-Match matches server ETag Oct 10, 2024
@Alex-302
Copy link
Member

@SukkaW But

To avoid overloading AdGuard's server/CDN, I've implemented a cache based on ETag

Do you have many clients? One user usually is not a problem for servers)
Also our filters support diff-update
https://filters.adtidy.org/extension/chromium/patches/18/18-s-1729265794-3600.patch
AdguardTeam/FiltersCompiler#192

@D13410N3
Copy link
Member

Hello.
Unfortunately it is not possible right now due to some filters update implementation reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Bug The issue is caused by a program bug
Projects
None yet
Development

No branches or pull requests

3 participants