Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include trusted- scriptlets in uBO version of lists #197

Open
superlex opened this issue Nov 8, 2023 · 5 comments
Open

Include trusted- scriptlets in uBO version of lists #197

superlex opened this issue Nov 8, 2023 · 5 comments
Assignees

Comments

@superlex
Copy link

superlex commented Nov 8, 2023

As of now, uBO version of lists don't inlcude trusted- scriptlets.
For example, compare Annoyances for uBO and Annoyances for AG/Firefox.

Since uBO supports them (trusted-click-element, trusted-set-cookie, etc.) it could be an idea adding them in uBO version of lists, so advanced users can take advantage of these AG rules.

Keep in mind that for standard users nothing changes:
gorhill/uBlock@64c1f8767c

@ameshkov
Copy link
Member

ameshkov commented Nov 9, 2023

As I understand, trusted scriptlets in uBO are only allowed in the lists maintained by the uBO team, is that right?

@superlex
Copy link
Author

superlex commented Nov 9, 2023

Hi @ameshkov 🙂
By default yes, trusted scriptlets are only allowed in the uBO lists. However a user can add adguard- token to trustedListPrefixes in order to allow trusted- scriptlets in stock AdGuard lists too.

@slavaleleka
Copy link
Contributor

AdGuard trusted scriptlets are not compatible with any other blocker by desing
https://github.com/AdguardTeam/Scriptlets/#trusted-scriptlets-restriction

i.e. trusted scriptlet rules are intentionally skipped during the build of the uBO version of AdGuard filter lists

@ameshkov
Copy link
Member

@slavaleleka well, that's the policy of our apps. uBO has a similar policy, i.e. it won't trust our scriptlets right away. But we can still include them into uBO list versions nevertheless, it's up to the user to decide.

@superlex
Copy link
Author

superlex commented Nov 10, 2023

it's up to the user to decide

Exactly, that's the point.
For a normal user nothing changes, he must accept the risks to enable advanced mode (and therefore enable adguard trusted scriptlets):
https://github.com/gorhill/uBlock/wiki/Advanced-user-features

Btw, an advanced user can also add other AG lists that contain AG trusted scriptlets (e.g. AG lists for AG_ext/Firefox) and use them:

dd

(this is a rule of AG Annoyances for AG_ext/Firefox)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants