Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard or regex support for domain name (not domain zone) #2303

Closed
tumatanquang opened this issue Mar 18, 2023 · 2 comments
Closed

Wildcard or regex support for domain name (not domain zone) #2303

tumatanquang opened this issue Mar 18, 2023 · 2 comments

Comments

@tumatanquang
Copy link

          > @tumatanquang Hi! Wildcard for domain name (not domain zone) - it is not safe because there can be wrong blocking with another useful sites

I'm not sure which of the "another useful sites" you're referring to, but domains that are nearly identical (or only partially different) will often be the same owner or will be alias of each other or even phishing domains.
If the wildcard for the domain is not safe, I hope there is another solution, like regex support for the domain name. In this case, perhaps the regex will be a little faster than the wildcard.

Originally posted by @tumatanquang in #2297 (comment)

@kodiakhub
Copy link

Do you mean this feature? 👉 AdguardTeam/CoreLibs#1550

Believe me, I've been waiting for a long time. 😄

Even if the feature may not be entirely safe for AdGuard, but it is quite useful for users, meaning for User rules. 👍

@mozartinio
Copy link

@tumatanquang
I reopen #2297 and going to close this issue as dublicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants