diff --git a/rebar.config b/rebar.config index 3416985..5731eb8 100644 --- a/rebar.config +++ b/rebar.config @@ -32,9 +32,7 @@ {project_plugins, [{rebar3_hex, "~> 7.0.1"}, - {rebar3_format, "~> 1.2.0"}, + {rebar3_format, "~> 1.2.1"}, {rebar3_lint, "~> 1.1.0"}, {rebar3_hank, "~> 1.3.0"}, {rebar3_sheldon, "~> 0.4.2"}]}. - -{hank, [{ignore, [{"test/*.erl", unnecessary_function_arguments}]}]}. diff --git a/src/lhttpc.erl b/src/lhttpc.erl index 7e7d76c..192921c 100644 --- a/src/lhttpc.erl +++ b/src/lhttpc.erl @@ -31,6 +31,9 @@ %%% @end -module(lhttpc). +%% catch X is used as a way to fire and forget, ignoring errors if there are any +-elvis([{elvis_style, no_catch_expressions, disable}]). + -behaviour(application). %% this is the API module; xref ignore all exports diff --git a/src/lhttpc_client.erl b/src/lhttpc_client.erl index 0a66eef..5a2bfca 100644 --- a/src/lhttpc_client.erl +++ b/src/lhttpc_client.erl @@ -32,6 +32,9 @@ %%% not be called directly since it should be spawned by the lhttpc module. -module(lhttpc_client). +%% Throw is used correctly in this module as a nonlocal return within a large function +-elvis([{elvis_style, no_throw, disable}]). + -export([request/10]). %% @todo Remove this once https://github.com/inaka/elvis_core/issues/170 is fixed. diff --git a/test/lhttpc_tests.erl b/test/lhttpc_tests.erl index 18a562c..caa4a40 100644 --- a/test/lhttpc_tests.erl +++ b/test/lhttpc_tests.erl @@ -27,6 +27,9 @@ %%% @author Oscar Hellstrom -module(lhttpc_tests). +%% eunit :'( +-hank([unnecessary_function_arguments]). + %% Macros in binary constructions. -format ignore. -elvis ignore. diff --git a/test/simple_load.erl b/test/simple_load.erl index a9ea243..8973a6c 100644 --- a/test/simple_load.erl +++ b/test/simple_load.erl @@ -1,5 +1,8 @@ -module(simple_load). +%% eunit :'( +-hank([unnecessary_function_arguments]). + -export([start_client/2, start_client/3]). -export([client/2]). -export([start_server/0]).