Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erratic coverage reports #189

Closed
ErikBjare opened this issue Nov 23, 2020 · 2 comments
Closed

Erratic coverage reports #189

ErikBjare opened this issue Nov 23, 2020 · 2 comments

Comments

@ErikBjare
Copy link
Member

As has been the case for some time now, coverage is erratic.

I tried to figure out the cause, but after looking at the Makefile and CI workflow I'm not finding anything that could be the culprit (I thought it could have something to do with the cache, but now I'm not so sure since the cache keys seem to be correctly set).

Do you still not have any lead @johan-bjareholt?
@ErikBjare
Copy link
Member Author

ErikBjare commented Nov 26, 2020 •
edited
Loading

We should probably adopt the recently-announced "source-based coverage": https://blog.rust-lang.org/inside-rust/2020/11/12/source-based-code-coverage.html

Seems like support has landed in grcov.

Edit: apparently source-based coverage has a lot of benefits, like supporting proc macros: mozilla/grcov#494 (comment)

@ErikBjare ErikBjare mentioned this issue Nov 26, 2020
Merged
@ErikBjare
Copy link
Member Author

Fixed in #192

@ErikBjare ErikBjare mentioned this issue Dec 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ErikBjare