Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Scale Performance: Sharrow Off #13

Open
dhensle opened this issue May 7, 2024 · 5 comments
Open

Full Scale Performance: Sharrow Off #13

dhensle opened this issue May 7, 2024 · 5 comments
Labels
performance-checks Issues that report on model performance

Comments

@dhensle
Copy link
Contributor

dhensle commented May 7, 2024

This is the issue to report on memory usage and runtime performance without using sharrow...

@dhensle dhensle added the performance-checks Issues that report on model performance label May 7, 2024
@dhensle
Copy link
Contributor Author

dhensle commented May 7, 2024

Ran with a 100 percent sample and single process. Machine has 1TB of RAM and a 2.79 GHz CPU. Memory peaks at about 240GB. Run time was approximately 21 hours.

image

logs.zip

@dhensle
Copy link
Contributor Author

dhensle commented May 7, 2024

Multiprocessing:

households_sample_size: 0 (100 percent sample)
sharrow: False
multiprocessing: True
num_processors: 24

Completed in 173 minutes, or 2.9 hours
log_no_sh_full_mp.zip

@dhensle
Copy link
Contributor Author

dhensle commented Jul 18, 2024

Varying the number of cores on the RSG machine with 500 GB of RAM and 24 cores. (Same exercise as performed for the abm3 model here)

image

Observations:

  • Same sort of diminishing returns as seen in all the other profiling runs when adding more and more cores.
  • Interestingly, there was no inflection point for the MTC model -- more cores means lower runtime. This was different with sharrow on and different compared to both sharrow on and off ABM3 benchmarking runs.

@asiripanich-dtp
Copy link

@dhensle – Thanks for sharing these benchmark results. Do you have similar benchmarks using ActivitySim v1.2? It would be really interesting to see how much improvement in both runtime performance and memory usage the new version shows compared to v1.2.

@dhensle
Copy link
Contributor Author

dhensle commented Nov 13, 2024

@asiripanich-dtp -- I do not directly have those comparisons, but you can find some of that work / discussion in this issue: ActivitySim/activitysim#904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance-checks Issues that report on model performance
Projects
None yet
Development

No branches or pull requests

2 participants