♻️ Consider line without a translation empty

Author: Lukáš Horák

packages/lokse/src/core/__tests__/line.test.ts

@@ -26,10 +26,28 @@ describe("Line.getComment", () => {
 });
 
 describe("Line.isEmpty", () => {
-  const line1 = new Line(null, null);
+  it("returns true if key is missing", () => {
+    const line = new Line(null, 'Translation with missing key');
+  
+    expect(line.isEmpty()).toEqual(true);
+    expect(line.isComment()).toEqual(false);
+
+  });
+
+  it("returns true if translation is missing", () => {
+    const line = new Line('missing.translation.key', null);
+  
+    expect(line.isEmpty()).toEqual(true);
+    expect(line.isComment()).toEqual(false);
 
-  expect(line1.isEmpty()).toEqual(true);
-  expect(line1.isComment()).toEqual(false);
+  });
+
+  it("returns true if both key and translation are missing", () => {
+    const line = new Line(null, null);
+
+    expect(line.isEmpty()).toEqual(true);
+    expect(line.isComment()).toEqual(false);
+  });
 });
 
 describe("Line", () => {

packages/lokse/src/core/line.ts

@@ -86,7 +86,7 @@ class Line {
   }
 
   isEmpty() {
-    return !this.isComment() && !this.key;
+    return !this.isComment() && !(this.key && this.value);
   }
 
   isComment() {

packages/lokse/src/core/reader/__tests__/spreadsheet-reader.test.ts

@@ -122,7 +122,7 @@ describe("SpreadsheetReader", () => {
       });
     });
 
-    it("should omit sheet in map lines when extracting from any fail", async () => {
+    it("should omit sheet in map lines when extracting fail from any reason", async () => {
       expect.assertions(4);
 
       const sheetsList = [

packages/lokse/src/core/writer.ts

@@ -23,7 +23,7 @@ export class FileWriter {
 
       fileContent = fileContent.toString();
     } catch {
-      // file doesnt exist
+      // file doesnt exist yet
     }
 
     const valueToInsert = this.getTransformedLines(lines, transformer);
@@ -43,21 +43,22 @@ export class FileWriter {
       const line = lines[i];
       const isLastLine = i === lines.length - 1;
 
-      if (!line.isEmpty()) {
-        if (line.isComment()) {
-          valueToInsert += transformer.transformComment(line.getComment());
-        } else if (line.isPlural()) {
-          if (!plurals[line.key]) {
-            plurals[line.key] = [];
-          }
-          plurals[line.key].push(line);
-        } else {
-          valueToInsert += transformer.transformKeyValue(line.key, line.value);
+      if (line.isEmpty()) {
+        continue;
+      }
+
+      if (line.isComment()) {
+        valueToInsert += transformer.transformComment(line.getComment());
+      } else if (line.isPlural()) {
+        if (!plurals[line.key]) {
+          plurals[line.key] = [];
         }
+        plurals[line.key].push(line);
+      } else {
+        valueToInsert += transformer.transformKeyValue(line.key, line.value);
       }
 
       if (
-        line.key !== "" &&
         !line.isPlural() &&
         (!isLastLine || Object.keys(plurals).length > 0)
       ) {