Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third-party dependencies in the release note are blocked by some countries firewalls #28

Open
RobertNorthard opened this issue Nov 21, 2016 · 0 comments

Comments

@RobertNorthard
Copy link
Contributor

RobertNorthard commented Nov 21, 2016

The release note depends on Google APIs. Google may be blocked in certain countries and therefore the release note does not render correctly (see screenshot below). Therefore I believe it would be best to add the dependencies locally when the release note is built. Alternatively we could use another CDN.

Adding the dependencies locally has a number of benefits;

  • Cross region support and no reliance on third-parties.
  • Security - stop potential injection of malicious scripts by third-parties (unlikely)

Third-party dependencies (not all are blocked)

Screenshot (Actual)

actual

Expected

expected

This also affects the adop-docker-compose wiki (http://accenture.github.io/adop-docker-compose)

@RobertNorthard RobertNorthard changed the title Features of the release note are blocked by country firewalls Third-party dependencies in the release note are blocked by some countries firewalls Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant