Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract_adapters: plugin docs generation fails when hook is present #1643

Closed
timlehr opened this issue Aug 1, 2023 · 1 comment
Closed
Labels
bug A problem, flaw, or broken functionality.

Comments

@timlehr
Copy link
Contributor

timlehr commented Aug 1, 2023

Before opening a bug report, please search open and closed issues to see if the problem has already been addressed. If there is such a report, and your issue is not adequately addressed there, please reference the issues in your new report.

Bug Report

On the extract_adapters branch there is an issue with the plugin docs generation / tests. If there are hooks with hook scripts in the path, the code doesn't handle them correctly and we get an error:

======================================================================
ERROR: test_plugin_documentation (test_serialized_schema.PluginDocumentationTester)
Verify that the plugin manifest matches what is checked into the
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/tlehr/dev/OpenTimelineIO/tests/test_serialized_schema.py", line 62, in test_plugin_documentation
    sanitized_paths=True
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/opentimelineio/console/autogen_plugin_documentation.py", line 337, in generate_and_write_documentation_plugins
    sanitized_paths
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/opentimelineio/console/autogen_plugin_documentation.py", line 283, in _manifest_formatted
    if manifest_paths and plug['from manifest'] not in manifest_paths:
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/opentimelineio/core/_core_utils.py", line 223, in __getitem__
    return self.__internal_getitem__(index)
TypeError: __internal_getitem__(): incompatible function arguments. The following argument types are supported:
    1. (self: opentimelineio._otio.AnyVector, index: int) -> object

Invoked with: ['studio_pre_write_hook'], 'from manifest'

----------------------------------------------------------------------
@timlehr timlehr added the bug A problem, flaw, or broken functionality. label Aug 1, 2023
@apetrynet
Copy link
Contributor

Fixed in PR #1644

@reinecke reinecke added this to the Public Beta 17 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem, flaw, or broken functionality.
Projects
None yet
Development

No branches or pull requests

3 participants