-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<materialassign> elements not processed in-order in MaterialXView #1108
Comments
Good catch @pablode . This was fixed for the Web viewer but I guess the desktop version needs some tweaking. |
I did an experiment with this, but would want to discuss this with @jstone-lucasfilm when he's back. The actual look logic is correct but it's been re-ordered based on material first. I'll leave it as is for now as I don't have bandwidth to look at this any more. The combined code for this and the #1109 issue can be found here (branch of a branch) |
@jstone-lucasfilm, actually #1113 only fixes parenting. Desktop ordering was not fixed, though it works on web. New PR is up for this, but there are no udim tests so please have a look as I'm unsure if this change has any side-effects. Thanks. |
The spec says on p. 71 in "MaterialAssign Elements" that "assign declarations should be processed in the order they appear in the file, and if any geometry appears in multiple <materialassign>s, the last <materialassign> wins".
However, this behaviour can not be observed in MaterialXView.
To reproduce, load the shaderball.glb geometry and following document:
The Blue material is assigned, but it should be Red.
The text was updated successfully, but these errors were encountered: