Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defaultProps #121

Merged
merged 7 commits into from
Sep 23, 2023
Merged

Remove defaultProps #121

merged 7 commits into from
Sep 23, 2023

Conversation

danielfrg
Copy link
Contributor

Fixes #119

AaronCCWong
AaronCCWong previously approved these changes Sep 23, 2023
View reviewed changes
Copy link
Owner

@AaronCCWong AaronCCWong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for putting this together!

@AaronCCWong AaronCCWong dismissed their stale review September 23, 2023 17:47

Conflicting variable declarations

AaronCCWong
AaronCCWong requested changes Sep 23, 2023
View reviewed changes
src/ReactCardFlip.tsx Show resolved Hide resolved
@AaronCCWong AaronCCWong merged commit 483f75b into AaronCCWong:master Sep 23, 2023
0 of 4 checks passed
@danielfrg
Copy link
Contributor Author

Thanks for the lib and the quick new release! Very helpful!

@danielfrg
Copy link
Contributor Author

For some reason I still hit #119 after updating. Maybe you forgot to run npm run build to update the compiled code?

@danielfrg danielfrg deleted the patch-1 branch September 24, 2023 07:07
@AaronCCWong
Copy link
Owner

Thanks for pointing this out! Updated

@danielfrg
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronCCWong AaronCCWong AaronCCWong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for defaultProps will be removed
2 participants
@danielfrg @AaronCCWong