Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Bad API auth with certain passwords #16797

Open
4 of 6 tasks
Rudd-O opened this issue Jan 14, 2025 · 2 comments
Open
4 of 6 tasks

[Bug]: Bad API auth with certain passwords #16797

Rudd-O opened this issue Jan 14, 2025 · 2 comments
Labels
bug-report Report of a bug, yet to be confirmed

Comments

@Rudd-O
Copy link

Rudd-O commented Jan 14, 2025

Checklist

  • The issue exists after disabling all extensions
  • The issue exists on a clean installation of webui
  • The issue is caused by an extension, but I believe it is caused by a bug in the webui
  • The issue exists in the current version of the webui
  • The issue has not been reported before recently
  • The issue has been reported before but has not been fixed yet

What happened?

Jan 14 13:14:03 roxanne.dragonfear stable-diffusion-webui[1682746]: ValueError: too many values to unpack (expected 2)

The routine in api.py is using auth.split(":")

It should be using auth.partition(":") to avoid double-splits.

Steps to reproduce the problem

Just run the thing with an API password that contains colons.

What should have happened?

Should start normally.

What browsers do you use to access the UI ?

No response

Sysinfo

Doesn't matter. It's a code bug.

Console logs

Above.

Additional information

No response

@Rudd-O Rudd-O added the bug-report Report of a bug, yet to be confirmed label Jan 14, 2025
@w-e-w
Copy link
Collaborator

w-e-w commented Jan 17, 2025

It should be using auth.partition(":") to avoid double-splits.

sure, partition or str.split(':', maxsplit=1)
but maybe it's better to just not use the second colon in your password

@manea19

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-report Report of a bug, yet to be confirmed
Projects
None yet
Development

No branches or pull requests

3 participants