Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS Review] Re-enable rh5v2 examples or document that they currently do not work #114

Closed
sea-bass opened this issue Nov 20, 2024 · 1 comment

Comments

@sea-bass
Copy link

sea-bass commented Nov 20, 2024

While testing this package, I noticed that the rh5v2 examples are commented out from the CMakeLists.txt with a comment saying they are broken.

Ideally this would be fixed before a submission, but if not possible please add comments in the documentation that these are currently not working. If the maintainers are too busy to resolve this, I would recommend creating an issue with some guidelines for contributors to help out.

openjournals/joss-reviews#6696

@dmronga
Copy link
Contributor

dmronga commented Nov 30, 2024

I fixed the rh5v2 tutorial, on velocity level, however. Instead I added another tutorial to show acceleration-level WBC

@dmronga dmronga closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants