Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inverseRotate() appears miss an overload for Euler-types #99

Open
markusgft opened this issue Jan 21, 2018 · 1 comment
Open

inverseRotate() appears miss an overload for Euler-types #99

markusgft opened this issue Jan 21, 2018 · 1 comment

Comments

@markusgft
Copy link

Hi all,
I just stumbled across a bug.
Here's a minimal description:

when calling inverseRotate() on Euler types, I observe the following.

Minimal example:
kindr::EulerAnglesXyz<SCALAR> euler1; euler1.setRandom();

kindr::EulerAnglesXyz<SCALAR> euler2; euler2.setRandom();

kindr::EulerAnglesXyz<SCALAR> euler3 = euler1.inverseRotate(euler2);

Desired behaviour:

  • inverse rotate should implement euler1.inverted() * euler2;

Current behaviour:

  • it simply returns euler3 = euler2;

I am not too much familiar with the details of the kindr implementation, but probably inverseRotate() does not get overloaded correctly. Alternatively, inverseRotate() should probably throw a compiler error, if called on wrong types.

@gehrinch
Copy link
Member

Hi Markus,

the method inverseRotate() should only transform a 3D-Vector. It does not invert the rotation. It should have thrown a compiler error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants