Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gif #7

Closed
wants to merge 22 commits into from
Closed

add gif #7

wants to merge 22 commits into from

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Aug 7, 2021

@casperdcl casperdcl added the enhancement New feature or request label Aug 7, 2021
@casperdcl casperdcl requested a review from pjmark August 7, 2021 15:56
@casperdcl casperdcl self-assigned this Aug 7, 2021
@casperdcl casperdcl changed the base branch from master to devel August 7, 2021 15:56
amypad/rectrim.py Outdated Show resolved Hide resolved
tests/test_rectrim.py Outdated Show resolved Hide resolved
amypad/gif.py Outdated Show resolved Hide resolved
amypad/gif.py Outdated Show resolved Hide resolved
amypad/rectrim.py Outdated Show resolved Hide resolved
amypad/rectrim.py Outdated Show resolved Hide resolved
amypad/rectrim.py Outdated Show resolved Hide resolved
amypad/imtrimup.py Outdated Show resolved Hide resolved
scripts/__init__.py Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

flake8

scripts/amypet_gif.py|104 col 1| W293 blank line contains whitespace
scripts/amypet_gif.py|105 col 25| E225 missing whitespace around operator
scripts/amypet_gif.py|106 col 89| E501 line too long (133 > 88 characters)
scripts/amypet_gif.py|114 col 27| E225 missing whitespace around operator
scripts/amypet_gif.py|114 col 44| E225 missing whitespace around operator
scripts/amypet_gif.py|116 col 17| E265 block comment should start with '# '
scripts/amypet_gif.py|118 col 17| E701 multiple statements on one line (colon)
scripts/amypet_gif.py|121 col 13| E303 too many blank lines (2)
scripts/amypet_gif.py|121 col 89| E501 line too long (90 > 88 characters)
scripts/amypet_gif.py|123 col 89| E501 line too long (100 > 88 characters)
scripts/amypet_gif.py|126 col 1| E265 block comment should start with '# '
scripts/amypet_gif.py|126 col 54| W292 no newline at end of file
scripts/amypet_gif.py|126 col 54| W292 no newline at end of file
scripts/amypet_gif.py|126 col 54| W292 no newline at end of file

scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
scripts/amypet_gif.py Outdated Show resolved Hide resolved
Base automatically changed from devel to master October 5, 2021 11:41
@casperdcl casperdcl changed the title add rectrim, gif add gif Nov 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2021

Codecov Report

Merging #7 (3ac830f) into master (1af0de5) will decrease coverage by 1.48%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   58.48%   57.00%   -1.49%     
==========================================
  Files           8        9       +1     
  Lines         277      300      +23     
==========================================
+ Hits          162      171       +9     
- Misses        115      129      +14     
Impacted Files Coverage Δ
amypad/gif.py 27.27% <27.27%> (ø)
amypad/gui.py 72.90% <100.00%> (+0.17%) ⬆️
amypad/utils.py 25.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af0de5...3ac830f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gif
3 participants