Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme list icons are incorrect; missing the red N (New) overlay #48

Open
regan-sarwas opened this issue Dec 29, 2021 · 1 comment
Open

Comments

@regan-sarwas
Copy link
Member

The problem started sometime around May/June of 2021. The N is often missing despite a publication date newer than the "Since" settings. Problem can be reproduced in a simple test theme list. The prior release (before May/June 2021) works correctly.

@regan-sarwas
Copy link
Member Author

I believe the problem is due to the change in the setter of the PubDate property in TMNode.cs.

_pubDate = value; at the start of the setter
and
OnPropertyChanged("PubDate"); at the end of the setter
were replaced by
SetObservableField(ref _pubDate, value); at the end of the setter.

The problem is the _pubDate needs to be set before calling CalcDaysSinceMyPublication() because that function reads the field (can you say spaghetti code).

Move SetObservableField(ref _pubDate, value); (which sets _pubDate) to the start of the setter. It shouldn't hurt to publish the change before doing the other tasks in the setter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant