Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node title and slots are always reset. #214

Open
rgthree opened this issue Apr 20, 2024 · 3 comments
Open

Node title and slots are always reset. #214

rgthree opened this issue Apr 20, 2024 · 3 comments

Comments

@rgthree
Copy link

rgthree commented Apr 20, 2024

Hello. Recently, rgthree-comfy made a change which allows other so other extensions' onNodeCreated to run for all of the rgthree-comfy nodes. Before this, some rgthree-comfy nodes did not call out to this method.

In doing so, there was with AIGODLIKE-ComfyUI-Translation which is now fixed from the rgthree-comfy side. However, in diagnosing, I noticed that node titles were overridden and slot names were always set, even when they were not previously.

Most notably "Reroute (rgthree)" nodes are now being fed into AIGODLIKE-ComfyUI-Translation's onNodeCreated which were not before and I now notice that reroutes have a floating label; presumably because this extension is setting the label when it was purposefully set to an empty string before. I'll leave it up to this extension on how you'd like to handle it; either skipping reroute nodes, or skipping nodes that are small sizes, or just not overwriting labels that are already not using the default.

(Also, I noticed custom node titles I had set were always overridden. Not sure if that was the intention here, but I wasn't expecting that).

Thanks

@KarryCharon
Copy link
Collaborator

KarryCharon commented Apr 24, 2024

@rgthree The name field of node is used for translating the node name in display(caz label field do nothing for node). And both in/out sockets and widgets label fields are used for translating respective. That's why the node name always be set if AIGODLIKE-ComfyUI-Translation is enabled.

@K-O-N-B
Copy link

K-O-N-B commented Jul 26, 2024

is this problem can be fix pls?

@KarryCharon
Copy link
Collaborator

is this problem can be fix pls?

We've submitted a pr to fix node panel display: comfyanonymous/ComfyUI#4112
For the node sockets both inputs and outputs we only change the label field for translation not the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants