Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observation Stacking #51

Closed
xiedidan opened this issue Jan 7, 2021 · 3 comments
Closed

Observation Stacking #51

xiedidan opened this issue Jan 7, 2021 · 3 comments

Comments

@xiedidan
Copy link

xiedidan commented Jan 7, 2021

It seems your code doesn't consider time series of observations?
Since there'll be no recurrent policy in stable baselines3 before v1.2, current implementation only takes 1 day's observation into consideration.
Did I miss anything that creates time series implicitly?

@YangletLiu
Copy link
Contributor

Yes, we haven't used observations of several time slots, currently it uses 1 day's observation (price, share). Using LSTM to encode a time series of observations into a latent state is promising. Do you have some idea that worth a trial? Thanks.

@xiedidan
Copy link
Author

I simply stacked 30 days' state, but no better result. Will give LSTM a try, thanks.

@YangletLiu
Copy link
Contributor

Join the slack channel, can have better discussions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants