Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only works with AWS_PRELOAD_METADATA=True #2

Closed
alanjds opened this issue Mar 25, 2013 · 6 comments
Closed

Only works with AWS_PRELOAD_METADATA=True #2

alanjds opened this issue Mar 25, 2013 · 6 comments

Comments

@alanjds
Copy link
Contributor

alanjds commented Mar 25, 2013

It still copies over everything if AWS_PRELOAD_METADATA=False, as storage.entries is empty in this case.

I dont know how to solve it yet.

@olofsj
Copy link
Contributor

olofsj commented Mar 25, 2013

That's true. However, without preloading the metadata it would need to make a separate request to S3 per file to check if it that file needs to be updated. That should be a little faster than uploading all files, but maybe not much faster.

@alanjds
Copy link
Contributor Author

alanjds commented Mar 25, 2013

I am thinking in a way to force to preload_metadata if is not set, but only for collectstatic command...

@alanjds
Copy link
Contributor Author

alanjds commented Mar 25, 2013

My problem is that letting AWS_PRELOAD_METADATA=True eats about 2sec from my Heroku dyno startup. This is a lot for me.

@olofsj
Copy link
Contributor

olofsj commented Mar 25, 2013

I see. Preloading the metadata only in the collect static command sounds like a nice idea. Let me know if you get it working.

@olofsj
Copy link
Contributor

olofsj commented Mar 25, 2013

I think I found an easy way to always preload the metadata in the collect static command, even if AWS_PRELOAD_METADATA=False. Please try bd79483 and see if it works for you.

@olofsj olofsj closed this as completed Mar 25, 2013
@alanjds
Copy link
Contributor Author

alanjds commented Mar 25, 2013

Thanks. It worked. In the meantime I had implemented the same here.

I think its better to log the change... Sent a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants