Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

Allow setting custom namespace value for metric filters #142

Open
et304383 opened this issue Sep 30, 2020 · 6 comments · May be fixed by #178
Open

Allow setting custom namespace value for metric filters #142

et304383 opened this issue Sep 30, 2020 · 6 comments · May be fixed by #178

Comments

@et304383
Copy link

This is a Feature Proposal

Description

For feature proposals:

  • We want to specify a custom namespace value so all of our custom metrics are under the same namespace value.
  • Currently, the metric filter metrics are going under their own namespace which is not great

Additional Data

  • Serverless Framework Version: 2.3.0
  • Stack Trace: N/A
  • Provider Error messages: N/A
@chrs-myrs
Copy link

@adikari We are looking at implementing this for our own purposes. If we can easily create a PR we will link it here for potential inclusion. Is there anything special we need to consider here?

@abdul-ashour is the developer looking into it.

@adikari
Copy link
Contributor

adikari commented May 10, 2021

@chrs-myrs first of all thank you for your interest in contributing. The proposed feature will surely help other users so happy to proceed.
Could you share how you are thinking of implementing this feature? Will it be a new optional configuration?

As long as the existing functionality is intact and the feature meets the test threshold requirements, it should be good.

@abdul-ashour
Copy link

@adikari I will just add an optional config forceCustomNamespace (I am happy to change the option name if you suggest one). If it is set to true and 'namespace' is also set, 'namespace' value will be used rather than the stack-name. Let me know If you have any concern about this approach. I can create the PR by end of today If you are happy with this approach. I am keeping in my mind backward compatibility.

@adikari
Copy link
Contributor

adikari commented May 11, 2021

@abdul-ashour sounds good to me. How about we call the option just namespace?

@abdul-ashour
Copy link

Just to confirm, there is no need in such a case for an additional option as namespace is already there. It will be used If it is set. Otherwise, it will be either the default value or stack-name (depending on whether there is a pattern defined or not).

@abdul-ashour
Copy link

I created the PR and happy to discuss any requested change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants