Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead project? #156

Closed
Beat707 opened this issue Dec 23, 2018 · 31 comments
Closed

Dead project? #156

Beat707 opened this issue Dec 23, 2018 · 31 comments

Comments

@Beat707
Copy link

Beat707 commented Dec 23, 2018

Is really sad to see this project dead, really loved how it works. I can contribute with some coding but I can't get it working on the latest Android Studio on Windows. :-(

@Beat707
Copy link
Author

Beat707 commented Dec 23, 2018

I was able to fix the problem with this:

Add jcenter() along with mavenCentral() in your project level build.gradle file.

buildscript {
repositories {
mavenCentral()
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:2.2.0'
}
}

@Beat707
Copy link
Author

Beat707 commented Dec 23, 2018

Darn, still won't work. Several errors...

@AChep
Copy link
Owner

AChep commented Dec 23, 2018

@Beat707 can you post error logs here?

@WilliamKWusik
Copy link

Ah, yes, sorry, I will. ;-) I started with the original files, it told me to upgrade. I will re-start and post all screenshots and errors. Maybe something can be done.

@WilliamKWusik
Copy link

Here's a video of the first problem.
https://www.twitch.tv/williamkwusik/manager/edit/354509493

Plugin is too old, please update to a more recent version, or set ANDROID_DAILY_OVERRIDE environment variable to "b0898362cd3d22ee30b50e40837d4eb51dc34225"
Upgrade plugin to version 3.2.1 and sync project

@tjsuominen
Copy link

Any further interested contributions? I am not a developer, yet would love to see ACDisplay continue to develope and evolve further. I am planning to "shout" for this (= volunteers to pick up) in Reddit /r/androidapps) just to raise awareness. How I could contribute (if development volunteer(s) found) could be do some further UI / UX planning. Let's see...

@CarlosACepeda
Copy link
Collaborator

I'll be glad to help. @tjsuominen do you have a Fork?

@tjsuominen
Copy link

First what I did was initialize discussions (= trying to find interest among other devs if someone would eventually continue ACD development) over reddit (Link to discussion) and got response even from Artem himself ;-) It's a mixed bag ;-)

We can continue discussions here or there on reddit (perhaps a wider commnunity).

Please elaborate what you mean with the 'Fork'?

@CarlosACepeda
Copy link
Collaborator

CarlosACepeda commented Jun 5, 2019

Fork: a copy of the project basically.
I'll be glad to help, Im developing an app myself inspired by AcDisplay but I can contribute to this app too, to be alive again, however, as I read on the Reddit discussion, anyway, the android system currently does what AcDisplay did, so, this means obviously that the app must have new features

@CarlosACepeda
Copy link
Collaborator

CarlosACepeda commented Jun 5, 2019

As stated in the readme, the app should change the name, or clarify that is not official.
But i don't know how it will be this, maybe @AChep can make a comment on this? Making a fork, limits the possibility of adding new issues or PR's without waiting the repo owner to merge /deny the changes made

@AChep
Copy link
Owner

AChep commented Jun 5, 2019

@CarlosACepeda I'm fine with the fork being on GitHub with the same name, I'm against the fork being published on Play Store and having the same name

@CarlosACepeda
Copy link
Collaborator

Ah okay I see, but what about PR's and Issues people want to open, you can't open issues in a fork. 🙁 :/

@AChep
Copy link
Owner

AChep commented Jun 5, 2019

Ah okay I see, but what about PR's and Issues people want to open, you can't open issues in a fork. 🙁 :/

Congraz on getting a Collaborator status ;) You can now push to the repository

@CarlosACepeda
Copy link
Collaborator

Many thanks @AChep 😮
@tjsuominen please can you gather more devs on this?

@tjsuominen
Copy link

@CarlosACepeda I'll do my best on Reddit :-)

I think 1st priority would be "update" everything to work on Pie (include updating libraries). There's good feedback on the Reddit post as you are aware of. Excited should ACD continue it's lifecycle and get even better over time!

@AChep Any chance we'll see you contributing...? :)

@AChep
Copy link
Owner

AChep commented Jun 6, 2019

@CarlosACepeda I'll do my best on Reddit :-)

I think 1st priority would be "update" everything to work on Pie (include updating libraries). There's good feedback on the Reddit post as you are aware of. Excited should ACD continue it's lifecycle and get even better over time!

@AChep Any chance we'll see you contributing...? :)

Good chance next month, after I'll finish this semester at university.

@CarlosACepeda
Copy link
Collaborator

CarlosACepeda commented Jun 6, 2019

I think for now this month I'll be updating Libraries and such, at least compile the project, ha ha. while @AChep is at University.

@tjsuominen
Copy link

Any luck @CarlosACepeda on compiling / updating libraries? :)

@CarlosACepeda
Copy link
Collaborator

Im so busy at work, but today/tomorrow I'll do this and then write here again.

@tjsuominen
Copy link

Happy to see activity here in GH. IMO, the 1st priority should be update everything (build, libraries, code etc.) to a level that ACD is fully working with Android 9.0. I'm more than interested in contributing to the UI/UX design in the future (as for visual mockups etc.).

@CarlosACepeda
Copy link
Collaborator

We are thinking in a new feature where the user can pick a wallpaper instead of always using the default that the user has, maybe can you help with those mockups of an activity where the user does that? because I admit I'm not good with UI, 😄 , obviously sticking with AcDisplay colors and such.

@tjsuominen
Copy link

tjsuominen commented Jul 9, 2019

Checked into that briefly and I think there are plenty of samples / implementations and ideas available for that e.g. in https://android-arsenal.com/tag/157. Also please keep in mind that people already have wallchangers (eg. I use Muzei). Of course I understand that this (pick a wallpaper in AcD) is optional.

PS. Should we now take these feature/bug etc. discussions outside of this (NOT)Dead-Project discussions :D

@tjsuominen
Copy link

Hi @CarlosACepeda and @AChep - just out of my huge curiosity - have you been able to start "spring cleaning" the code already or mostly going through the issues / feedback on GitHub? Take your time! :)

@CarlosACepeda
Copy link
Collaborator

In my case I'm still not being able to build the project :/
I already contacted @AChep and he said that's he's working on that basically, but I don't know really how's that process going :/

@tjsuominen
Copy link

Thx @CarlosACepeda for checking back, take your time :)

@CarlosACepeda
Copy link
Collaborator

CarlosACepeda commented Sep 2, 2019

Okay, I was able to build the project and update the Sdk Target to Android Oreo in the commit 8d2d1b1
So I will close the issue for now too.
For the OP @Beat707 : You must have to upgrade the Gradle file at Project level, using the instructions given from Android Studio for this task.
@ me if you have further questions.
So sync and tell me if it works.

image

@tjsuominen
Copy link

Hi @CarlosACepeda - great news! Does this mean that after a while we could expect a new release on Play Store that works on Pie based phones :)? Or is that still miles ahead?

@CarlosACepeda
Copy link
Collaborator

CarlosACepeda commented Sep 3, 2019

I will update again the App these days so it compiles on Android Pie, and check basic funcionality/or make fixes depending on the case of course
About a release, as I'm a new collaborator so basically I have to get used to the project structure and functionality to start really working on it without messing up lol, so it's probable that it'll take a while

@tjsuominen
Copy link

Brilliant - for sure it takes time! As a new build/release, how about releasing the APK to Github/APKMirror or such for beta testing prior to Play Store update? Just a thought :)

@CarlosACepeda
Copy link
Collaborator

Yes, that maybe would be an option,
Current debug version is +4.0.0!, I am really sorry for all the delays, but I can release a version myself for testing.
So far I've testing on my own device but of course it is not enough.

@AChep
Copy link
Owner

AChep commented Jul 17, 2020

Wow! Amazing work, I'm excited to see the patch changes and test the apk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants