Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnings field changes from string to array in bitcoin core 28 #2921

Open
DerEwige opened this issue Oct 8, 2024 · 3 comments
Open

warnings field changes from string to array in bitcoin core 28 #2921

DerEwige opened this issue Oct 8, 2024 · 3 comments

Comments

@DerEwige
Copy link
Contributor

DerEwige commented Oct 8, 2024

bitcoin core 28 comes with a breaking change in the warnings field:

bitcoin/bitcoin#29845

Has this already been taking into account in eclair

@t-bast
Copy link
Member

t-bast commented Oct 8, 2024

No, as documented eclair doesn't support bitcoind 28 yet. This would be use at your own risk!
We'll be updating to bitcoind 28 at some point, you should wait for this to be released before updating your bitcoin node.

@DerEwige
Copy link
Contributor Author

DerEwige commented Oct 8, 2024

I’m aware that bitcoind 28 is not yet supported.
It should work though when setting this in the config

deprecatedrpc=warnings

I assume you will want to move to it so you can make use of the package relay feature, to simplify CPFP in FC scenarios?

@t-bast
Copy link
Member

t-bast commented Oct 8, 2024

It's not as simple. We can only benefit from additional propagation once enough bitcoin nodes have upgraded to 28.

Also, updating to bitcoind 28 breaks some of our tests, which means we need to investigate what changed and make sure there's no regression in eclair when upgrading.

This will be done and included in a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants