Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code not recognised when in dark mode #101

Open
zpunout opened this issue Nov 20, 2022 · 5 comments
Open

QR code not recognised when in dark mode #101

zpunout opened this issue Nov 20, 2022 · 5 comments

Comments

@zpunout
Copy link

zpunout commented Nov 20, 2022

Tried to scan the QR code after setting the display to dark mode, but the other phone couldn't recognise it.

Light mode works fine

Steps to reproduce:

  1. Fresh install WhatsApp Web To Go
  2. Set display to dark mode
  3. Attempt to link device with QR code in WhatsAppWTG with camera on other device running official WhatsApp (by Meta)
  4. QR code will not be recognised
@92lleo
Copy link
Owner

92lleo commented Nov 20, 2022

Hi @zpunout
What phone do you use with the Meta Whatsapp installed?
I just tried to reconnect my Whatsapp Web To Go in dark mode with Whatsapp on Iphone, worked within a split second.

@shuvashish76
Copy link

Same issue.
Official WhatsApp v2.22.23.84 on Samsung J7 Prime, WhatsappWebToGo v1.7.3 (with dark mode) on Moto G71 5G.

@george124816
Copy link

same for me, light mode works fine.
Whatsapp Web To Go version 1.7.3 on Lenovo TB-J706F
Whatsapp v2.22.23.84 on Samsung S22+

@92lleo
Copy link
Owner

92lleo commented Dec 15, 2022

Thanks everyone for confirming. Also tried it with an android phone now, same issue. Seems like it's just working to scan the dark mode QR Code with an iPhone WhatsApp installation. I'll fix this with the next release, until then just switch to light mode for scanning

@JonasunderscoreJones
Copy link

JonasunderscoreJones commented Jan 27, 2023

Same issue here with dark mode not working.

Here also an explanation as to why it behaves that way for anyone who's interested:

QR codes require a so called quiet zone around their pixels which is a white margin, often 4 times the thickness of a single module to help the reader distinguish the code itself from it's background and surroundings. it appears that the qr code reader on iOS is smart enough to come around that issue??? (seems like something apple would do). Therefore for a qr code to work reliably and be compatible with the standard, it requires a white border around the modules.

EDIT: WhatsApp web has a built-in dark mode anyways and if you hide the top app bar it's just the same appealing dark mode as the app provides

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants