fix: rspec and rubocop

Author: marsz

.rubocop.yml

@@ -147,3 +147,6 @@ Lint/RescueWithoutErrorClass:
 
 Lint/AmbiguousRegexpLiteral:
   Enabled: false
+
+Metrics/ParameterLists:
+  Max: 8

app/builders/admin_breadcrumbs_builder.rb

@@ -13,7 +13,7 @@ def render
   def render_element(element)
     last = element == @elements.last
     @context.content_tag(:li, class: "breadcrumb-item #{'active' if last}") do
-      if element.path == nil || last
+      if element.path.nil? || last
         compute_name(element)
       else
         @context.link_to_unless_current(compute_name(element), compute_path(element), element.options)

app/helpers/admin_helper.rb

@@ -130,18 +130,18 @@ def admin_link_to(text, link, icon: nil, size: nil, color: nil, round: false, **
     end
   end
 
-  def admin_app_button_to(text, link, icon: , **html_opts)
+  def admin_app_button_to(text, link, icon:, **html_opts)
     html_opts ||= {}
     admin_link_to(text, link, icon: icon, class: "btn-app #{html_opts.delete(:class)}", **html_opts)
   end
 
   def admin_accordion(hash_data, &block)
     parent_id = 'accordion-parent' + hash_data.to_s.hash.to_s
-    value = hash_data.map do |title, value|
+    content = hash_data.map do |title, value|
       body = capture(title, value, &block)
       id = 'accordion' + "#{title}#{value}".hash.to_s
       render partial: 'admin/base/templates/accordion_item', locals: { title: title, body: body, id: id, parent_id: parent_id }
     end.join.html_safe
-    render partial: 'admin/base/templates/accordion', locals: { content: value, id: parent_id }
+    render partial: 'admin/base/templates/accordion', locals: { content: content, id: parent_id }
   end
 end

app/inputs/btn_group_input.rb

@@ -1,8 +1,7 @@
 class BtnGroupInput < SimpleForm::Inputs::CollectionRadioButtonsInput
 
   # https://github.com/plataformatec/simple_form/blob/master/lib/simple_form/inputs/collection_radio_buttons_input.rb
-  def input(wrapper_options = nil)
-
+  def input(_wrapper_options = nil)
     label_method, value_method = detect_collection_methods
 
     template.content_tag(:div, class: 'btn-group', 'data-toggle' => 'buttons') do

app/inputs/debug_sql_input.rb

@@ -15,7 +15,7 @@ def attribute_name
     :created_at_eq
   end
 
-  def label_text(*args)
+  def label_text(*_args)
     'Debug SQL'
   end
 end

app/inputs/is_deleted_input.rb

@@ -7,7 +7,7 @@ def collection
     [['Not Deleted', ''], ['Deleted', :only_deleted], ['All', :with_deleted]]
   end
 
-  def label_text(*args)
+  def label_text(*_args)
     'Deleted'
   end
 end

spec/support/data_maker.rb

@@ -17,7 +17,7 @@ def data_for_category
 
   def data_for_creating_category
     data_for_category.merge(
-      tag_list: 'a,b,c'
+      tag_list: ['a', 'b', 'c']
     )
   end