feat(ErrorHandler): add rendering for other formats

Author: Manic Chuang

app/controllers/errors_controller.rb

@@ -1,9 +1,17 @@
 class ErrorsController < ApplicationController
   def not_found
-    render(status: 404)
+    respond_to do |format|
+      format.json { render json: { message: 'Page not found' }, status: 404 }
+      format.html { render status: 404 }
+      format.any { render plain: 'Page not found', status: 404 }
+    end
   end
 
   def internal_server_error
-    render(status: 500)
+    respond_to do |format|
+      format.json { render json: { message: 'Internal Server Error' }, status: 500 }
+      format.html { render status: 500 }
+      format.any { render plain: 'Internal Server Error', status: 500 }
+    end
   end
 end

spec/requests/errors_controller_spec.rb

@@ -1,9 +1,24 @@
 require 'rails_helper'
 
 RSpec.describe ErrorsController, type: :request do
-  it '/404' do
-    get '/dasdasdasd'
-    expect(response.status).to eq(404)
-    expect(response.body).to include('looking for doesn\'t exist.')
+  context '/404' do
+    it 'html format' do
+      get '/dasdasdasd'
+      expect(response.status).to eq(404)
+      expect(response.body).to include('looking for doesn\'t exist.')
+    end
+
+    it 'json format' do
+      get '/not_a_valid_url.json'
+      expect(response.status).to eq(404)
+      response_json = JSON.parse(response.body)
+      expect(response_json['message']).to eq('Page not found')
+    end
+
+    it 'other format' do
+      get '/not_a_valid_url.test'
+      expect(response.status).to eq(404)
+      expect(response.body).to include('Page not found')
+    end
   end
 end