[18] - implements koans solutions #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanSolaDelgado
changed the base branch from
master
to
16-adjust-test-and-comments
IvanSolaDelgado
changed the title
4 tasks
AsierAlba10
approved these changes
Jul 13, 2023
|
|
||
| // Create a ForEach Loop to pass the test | ||
| $result = ''; | ||
| foreach ($age as $key => $value){ |
There was a problem hiding this comment.
Maybe you can refactor the names of the forEach
foreach ($age as $key => $value){ ->
foreach ($people as $name => $age){
| // Create a ForEach Loop to pass the test | ||
| $result = ''; | ||
| foreach ($age as $key => $value){ | ||
| $result .= "Key= $key, Value= $value ; "; |
There was a problem hiding this comment.
What do you think if we change the answer to make it look better?
"Key = $key, Value = $value ; "
| } | ||
|
|
||
| // Extract Joe´s Age | ||
| $this->assertEquals($result, "Key= Joe, Value= 49 ; Key= Mike, Value= 27 ; Key= Charles, Value= 32 ; "); |
| * @test | ||
| * @testdox Some ways of asserting equality are better than others | ||
| */ | ||
| public function checkHowMuchIsOnePlusOneUsingVariablesAndAssertEquals() |
There was a problem hiding this comment.
This test and checkHowMuchIsOnePlusOne(2 above) they are not repetitive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Notes