Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cob_bms_driver] charging flag cannot be used for docking status #308

Open
floweisshardt opened this issue Feb 3, 2017 · 1 comment
Open

[cob_bms_driver] charging flag cannot be used for docking status #308

floweisshardt opened this issue Feb 3, 2017 · 1 comment
Assignees
@fmessmer

Comments

@floweisshardt
Copy link
Contributor

floweisshardt commented Feb 3, 2017 •
edited by fmessmer
Loading

see discussion in https://github.com/ipa320/msh/issues/595#issuecomment-277238899.

this was caused by the charging flag from the bms switching to false as soon as the battery is full because there is no more current going into the battery.

Proper solution is to use a combination of the charging and battery_full flags and generate a docked status out of it. the PowerState message should be enhanced to have this additional flag.

@fmessmer FYI
@fmessmer
Copy link
Contributor

fmessmer commented Feb 3, 2017 •
edited
Loading

related workaround https://github.com/ipa320/cob_driver/pull/307 with discussion

@fmessmer fmessmer mentioned this issue Feb 9, 2017
Merged
@fmessmer fmessmer self-assigned this Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmessmer fmessmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@floweisshardt @fmessmer