added service id and service name headers when X-3scale-debug is used #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
reviewed
Feb 11, 2019
gateway/src/apicast/proxy.lua
Outdated
| @@ -85,6 +85,8 @@ local function output_debug_headers(service, usage, credentials) | |||
| ngx.header["X-3scale-credentials"] = credentials | |||
| ngx.header["X-3scale-usage"] = usage | |||
| ngx.header["X-3scale-hostname"] = ngx.var.hostname | |||
| ngx.header["X-3scale-svc-id"] = service.id | |||
There was a problem hiding this comment.
Why abbreviating to svc instead of using service?
There was a problem hiding this comment.
Just for readability X-3scale-service-name looked a really long name.
There was a problem hiding this comment.
@palmieric It is just one character more than X-3scale-credentials. I'd prefer service instead of svc.
There was a problem hiding this comment.
Ok will change it and resubmit
There was a problem hiding this comment.
You can just force push to this PR.
And you'll need a changelog entry.
There was a problem hiding this comment.
You'll still need to add a new entry to CHANGELOG.md file.
added 2 commits
February 11, 2019 17:11
mikz
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added info on the services in the response headers when using X-3scale-debug headers as asked in https://issues.jboss.org/browse/THREESCALE-1849