Extract condition modules from the Conditional policy #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So they can be used from other policies. Actually, we were already using the Condition and the Operation module from the Rate Limit policy. We had a dependency between policies, which is something we want to avoid.
davidor
force-pushed
the
extract-conditions-modules
branch
from
d445a30 to
70fd6ec
Compare
This was referenced Jan 3, 2019
mikz
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extract the condition modules so they can be used from other policies. Actually, we were already using the
Conditionand theOperationmodule from the Rate Limit policy. We had a dependency between policies, which is something we want to avoid.This is also needed for implementing the Routing policy (#972).