Delete operation in headers policy #928
Conversation
Unfortunately, there is no easy way to hide the "value" and "value_type" fields when the operation is "delete" in a schema that works with https://github.com/mozilla-services/react-jsonschema-form Dynamic schemas look like a possible solution but they do not work in arrays: https://github.com/mozilla-services/react-jsonschema-form#dynamic
| @@ -40,7 +44,7 @@ | |||
| "type": "string" | |||
| }, | |||
| "value": { | |||
| "description": "Value that will be added, set or pushed in the header", | |||
| "description": "Value that will be added, set or pushed in the header. Not needed when deleting.", | |||
There was a problem hiding this comment.
This solution is not ideal. When the operation is "delete", the form will show 2 fields (value and value_type) that will be ignored. However, I didn't find any better alternative that works with https://github.com/mozilla-services/react-jsonschema-form
Dynamic schemas look like a possible solution, we use them in the default credentials policy. However, in this policy, they do not work correctly because they would be defined in an array.
An alternative would be to keep the "operations" array as it is now and define a separate "headers_to_delete" field (array of strings), but I'm not sure that would be much better. For the end-user, having a separate field for the delete operation will not make much sense.
There was a problem hiding this comment.
I think this is fine. I think showing extra field is better than adding a whole new array just for deletes.
There was a problem hiding this comment.
Yeah, I agree. As long as it's clear that value is not required for deleting, it's OK.
| end) | ||
|
|
||
| describe('and the header is already set', function() | ||
| it('deletes it', function() |
There was a problem hiding this comment.
I wasn't totally sure about this one but decided to keep it working as it is now.
|
@davidor This one is not in the DR1 right? |
|
@mikz I have tested this on nightly, so far this works. |
Closes #922