README for the IP check policy #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add missing references to issues.
|
@3scale/qe would be good to get your feedback about this. Hopefully, it helps you understand how it works. |
|
Nice, thank you @davidor ! 👍 |
|
Hi @mikz , I am unable to edit the files. Do you want me to simply add comments and then you want to incorporate my feedback? Do let me know. Thanks :) |
|
@supriya-bharadwaj sorry for that, just have the @3scale/documentation team write permissions to the repo, so you should be free to edit the files in this PR. But anyway, PR comments are fine anyway! Any kind of feedback is much appreciated. 👍 |
|
@mikz Looks reasonable, but we will know more when we start with automation. |
mikz
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a README with examples for the IP check policy. Also, places the policy in the correct subsection of the changelog and adds a missing link to JIRA.