[rate-limit] Use shdict when redis_url is empty in the same way as redis_url is null. #842

y-tabata · 2018-08-13T08:12:04Z

Closes #834.

davidor · 2018-08-13T08:21:36Z

gateway/src/apicast/policy/rate_limit/rate_limit.lua

@@ -141,7 +141,7 @@ end

 function _M:access(context)
  local red
-  if self.redis_url then
+  if self.redis_url and self.redis_url ~= '' then


Do we need this in the checkin function too?

https://github.com/3scale/apicast/blob/54212cf5e0c62f1a5c4d3d4f775b3aa6b05eba78/gateway/src/apicast/policy/rate_limit/rate_limit.lua#L227

Changed, too.

use shdict when redis_url is empty in the same way as redis_url is null.

54212cf

y-tabata requested a review from a team as a code owner August 13, 2018 08:12

davidor reviewed Aug 13, 2018

View reviewed changes

change the checkin function

beb449c

davidor approved these changes Aug 13, 2018

View reviewed changes

CHANGELOG: add fix for empty redis_url in rate-limit policy

0e211df

davidor merged commit 5d44d3d into 3scale:master Aug 13, 2018

y-tabata deleted the redis-url-empty branch August 13, 2018 09:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[rate-limit] Use shdict when redis_url is empty in the same way as redis_url is null. #842

[rate-limit] Use shdict when redis_url is empty in the same way as redis_url is null. #842

y-tabata commented Aug 13, 2018

davidor Aug 13, 2018

y-tabata Aug 13, 2018

[rate-limit] Use shdict when redis_url is empty in the same way as redis_url is null. #842

[rate-limit] Use shdict when redis_url is empty in the same way as redis_url is null. #842

Conversation

y-tabata commented Aug 13, 2018

davidor Aug 13, 2018

Choose a reason for hiding this comment

y-tabata Aug 13, 2018

Choose a reason for hiding this comment