Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

methods for policy chain manipulation #505

Merged
merged 3 commits into from
Nov 28, 2017
Merged

Conversation

mikz
Copy link
Contributor

@mikz mikz commented Nov 28, 2017

It should be possible to load a policy chain and
add policies to it.
After this chain is added to the executor it should not be modified.

This is going to be a foundation of how to configure policy chain
by the environment configuration: #504

See the generated documentation: https://2580-53965666-gh.circle-artifacts.com/0/doc/modules/policy_chain.html

* 'require' calls are cached, so there can be just one
@mikz mikz force-pushed the policy-chain-manipulation branch from 85196ec to 25ad8b5 Compare November 28, 2017 12:07
mikz added 2 commits November 28, 2017 13:09
* freeze the chain when passed to the executor
* after freezing not possible to add policies
* provide default policy chain
* ability to insert policy to a chain
@davidor
Copy link
Contributor

davidor commented Nov 28, 2017

Just for reference, these commits were part of #496
I read our comments and discussions in that PR and everything looks good 👍

@davidor davidor merged commit 715a563 into master Nov 28, 2017
@davidor davidor deleted the policy-chain-manipulation branch November 28, 2017 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants