allow passing multiple environment configuration files #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
force-pushed
the
environment-configuration
branch
from
9483164 to
f558ebe
Compare
mikz
force-pushed
the
environment-configuration
branch
from
f558ebe to
40dfaaa
Compare
mikz
force-pushed
the
environment-configuration
branch
2 times, most recently
from
11d3ae7 to
47a7976
Compare
davidor
reviewed
Nov 28, 2017
| --- | ||
| -- @field default_environment Default environment name. | ||
| -- @table self | ||
| _M.default_environment = 'production' -- default environment name |
There was a problem hiding this comment.
nitpick: redundant comment
There was a problem hiding this comment.
looks like bad rebase, thanks!
davidor
reviewed
Nov 28, 2017
|
|
||
| local template = Template:new(context, dir, true) | ||
| local function apicast_root() | ||
| return resty_env.get('APICAST_DIR') or pl.path.abspath('.') |
There was a problem hiding this comment.
Ah didn't see that it's fixed in the second commit :)
The `-e` or `--environment` flag can be either and environment name or a path to a file. Plain names are resolved to the config directory in APIcast source.
* .value returns nil when the value is empty string * so it can be chain with `or` for a default value
mikz
force-pushed
the
environment-configuration
branch
from
47a7976 to
20504a8
Compare
davidor
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-eor--environmentCLI flag can be repeatedand it can be either an environment name or a path to a file
extracted from #496