[CVE-2017-7512] reject empty client secret #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3scale Service Management API would return 200 when app_key paramater was empty for legacy purposes. That was not expected by the gateway which was sending empty key for verification. This was fixed on 3scale Service Management API and empty app_key parameter will now return 409. However, gateway should not rely jsut on 3scale Service Management, so it performs own validation of the client secret during Access Token generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3scale Service Management API would return 200 when app_key paramater
was empty for legacy purposes. That was not expected by the
gateway which was sending empty key for verification.
This was fixed on 3scale Service Management API and empty app_key
parameter will now return 409.
However, gateway should not rely jsut on 3scale Service Management,
so it performs own validation of the client secret during Access Token
generation.