Fix OAuth auth caching #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From what I can see the only changes in They shouldn't even conflict. I've also noticed that the internal location contents were different for oauth and no-oauth, and this is indeed being fixed here: https://github.com/3scale/apicast/pull/283/files#diff-031add362afcf189262a1e0dc060ea7f (but I didn't touch it in this PR) I am not sure this bug fix should be merged with the new feature implementation by #283, because it's not related. But I can do it if you think it's better. |
|
@mayorova it is not committed yet. |
mikz
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that in OAuth mode the auth caching was not working (not sure if it never worked, the bug or was introduced at some point.
Also, I've decided to remove the duplication in
authrepandoauth_authrep, as only the internal location should be different for them. This can probably be improved further, by using the co-socket http library instead of internal locations.