Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to supply headers/modify the http request to fetch remote images #178

Open
dlvhdr opened this issue Jun 8, 2024 · 2 comments
Open

Comments

@dlvhdr
Copy link

dlvhdr commented Jun 8, 2024

Hi, thanks for the plugin.
I'm using octo.nvim to do code reviews and it presents the summary of the PR in neovim.
I would like to view the images in neovim as well.
These images are stored in a private github repo that I have access to, using my cookie/token.
Would it be possible to supply these when this plugin fetches the images?
Something like gh auth token will give me my github token that I can then supply this plugin with to fetch the remote images.

Thank you!

@3rd
Copy link
Owner

3rd commented Jun 8, 2024

Hey, would it be enough to make the arguments we send to curl configurable so you can pass --header?

@dlvhdr
Copy link
Author

dlvhdr commented Jun 13, 2024

So did more research and apparently github makes it really hard. They require both session cookie and a token. They then redirect to s3.
Makes it very hard to just use gh auth token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants